Skip to content

[WPB-8881] Move email update and remove operations to effects#4316

Merged
mdimjasevic merged 14 commits intodevelopfrom
wpb-8881/identity-update-ops
Nov 4, 2024
Merged

[WPB-8881] Move email update and remove operations to effects#4316
mdimjasevic merged 14 commits intodevelopfrom
wpb-8881/identity-update-ops

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Oct 29, 2024

This is a refactoring PR about user email update and remove operations.

Tracked by https://wearezeta.atlassian.net/browse/WPB-8881.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Oct 29, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 29, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch 9 times, most recently from 2d7c218 to c9cf837 Compare October 31, 2024 11:51
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch 2 times, most recently from 058bef6 to f3a4f89 Compare October 31, 2024 13:56
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch from f3a4f89 to 42830ed Compare October 31, 2024 15:33
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch from 42830ed to 0a6ab2c Compare October 31, 2024 15:40
@mdimjasevic mdimjasevic changed the title [WPB-8881] Identity update operations in Polysemy [WPB-8881] Move email update and remove operations to effects Oct 31, 2024
@mdimjasevic mdimjasevic marked this pull request as ready for review October 31, 2024 15:42
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch from 0a6ab2c to 2d0d1a7 Compare October 31, 2024 15:45
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch from 2d0d1a7 to a689502 Compare October 31, 2024 15:49
@mdimjasevic mdimjasevic force-pushed the wpb-8881/identity-update-ops branch from a689502 to acea7d2 Compare November 4, 2024 09:07
Marko Dimjašević added 2 commits November 4, 2024 10:19
This also changes the error type in RemoveEmailEither to the general
UserSubsystemError type. Handler-specific reinterpretations are done in
the handler instead.
@fisx fisx force-pushed the wpb-8881/identity-update-ops branch from e145dba to 3e4054f Compare November 4, 2024 13:20
@mdimjasevic mdimjasevic merged commit bbe3676 into develop Nov 4, 2024
@mdimjasevic mdimjasevic deleted the wpb-8881/identity-update-ops branch November 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants